-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the link to cluster-role-binding.md in mirroring-configuration.md #2580
Correct the link to cluster-role-binding.md in mirroring-configuration.md #2580
Conversation
WalkthroughWalkthroughThe documentation for the Vald Mirror Gateway configuration has been updated to enhance hyperlink accuracy. A link previously directing users to a relative path was modified to ensure correct navigation to the resource for cluster role settings. This change aims to improve the clarity and usability of the documentation while maintaining the core guidance provided. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
participant ClusterRoleBinding
User->>Documentation: Access mirroring configuration
Documentation->>User: Display configuration guide
User->>Documentation: Click on Cluster Role Binding link
Documentation->>ClusterRoleBinding: Redirect to Cluster Role Binding guide
ClusterRoleBinding-->>User: Display Cluster Role Binding information
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/user-guides/mirroring-configuration.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/user-guides/mirroring-configuration.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors please add @aknishid for doc |
I've put up a pull request to add @aknishid! 🎉 |
@aknishid can you overwrite your commit as signed? FYI: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Signed-off-by: aknishid <[email protected]>
1291147
to
3ad84cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/user-guides/mirroring-configuration.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/user-guides/mirroring-configuration.md
@kpango |
@aknishid Thanks!! |
The link to "Cluster Role Configuration" on the page https://vald.vdaas.org/docs/user-guides/mirroring-configuration/ was returning a 404 error.
The incorrect link was pointing to https://vald.vdaas.org/docs/user-guides/mirroring-configuration/cluster-role-binding.
I corrected the link path.
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit